Skip to content

CI never validates main: ci.yaml has no push trigger, so a direct push lands uncheckedΒ #342

Closed

Description

@devantler

πŸ€– Generated by the Agentic Engineer

Evidence

.github/workflows/ci.yaml triggers on pull requests only β€” there is no push trigger:

on:
  pull_request:
    branches: [main]

So nothing validates main itself. A commit that reaches main outside a pull request is never linted, type-checked, tested or built.

This is not hypothetical. Commit b1d6c664fc ("restore patched image tooling") landed directly on main β€” no (#N) suffix β€” and bumped lighthouse and puppeteer-core, rewriting the lockfile and growing the nested dependency tree from 2 entries to 26. No CI ran. The resulting breakage surfaced only indirectly, days later, as every open Dependabot PR failing all eight jobs at npm ci (#340).

Impact

  • A direct push can break main silently and stay broken until something unrelated trips over it β€” here, the entire dependency-update pipeline froze.
  • Automated health checks read default-branch CI runs. A repository with no push-triggered workflow produces no runs to fail, so it reports clean regardless of its actual state. The repository is invisible to breakage detection rather than healthy β€” the worse of the two, because nothing prompts a look.

Expected behaviour

CI runs against main as well as against pull requests, so the default branch carries a real, readable health signal.

Acceptance criteria

  • ci.yaml also triggers on push to main.
  • A run against main appears in the Actions tab and its conclusion reflects the branch's real state.
  • A concurrency group prevents a push run and a PR run for the same ref from duplicating work.

Rough size: small β€” a trigger block and a concurrency group.

Part of #91.

Activity

  1. added theissue type on Sep 20, 2026
  2. moved this to πŸ“₯ Backlog in 🌊 Project Boardon Sep 20, 2026
  3. added a commit that references this issue on Sep 22, 2026
  4. moved this from πŸ“₯ Backlog to πŸ‘€ In Review in 🌊 Project Boardon Sep 22, 2026
  5. moved this from πŸ‘€ In Review to βœ… Done in 🌊 Project Boardon Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    None yet

    Effort

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions