Skip to content

fix(scripts): give the caller-pin contract the template's file mode - #481

Merged
devantler merged 1 commit into
mainfrom
claude/match-template-script-mode
Nov 15, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/match-template-script-mode

Conversation

@devantler

Copy link
Copy Markdown
Contributor

What

The first template-sync after onboarding (#480) stopped on one merge conflict: scripts/workflow-caller-pin-contract.test.sh is template-owned and identical in content here, but this copy is 100755 while the template ships 100644. The sync merges the template's tree, and a mode-only difference on a file both sides add is an add/add conflict, which the sync workflow (now on devantler-tech/.github v21.6.2) correctly refuses to open a PR over (failed run).

This drops the executable bit so the file matches the template. CI, CONTRIBUTING.md and docs/REFERENCE.md all run it as sh scripts/workflow-caller-pin-contract.test.sh, so nothing depended on the bit.

Validation

  • sh scripts/workflow-caller-pin-contract.test.sh passes.
  • A local git merge-tree --allow-unrelated-histories of this repository's main with the template's main shows this file as the only conflict outside .templatesyncignore.
  • After merge, the Template Sync workflow runs once more to confirm its pull request opens.

🤖 Generated with Claude Code

The template ships scripts/workflow-caller-pin-contract.test.sh as 100644
and this copy was 100755, so the template-sync merge stops on an add/add
conflict for that path. Every caller runs it with sh, so it needs no
executable bit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T02:47:22.062370Z d92a062 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: d92a0621f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler
devantler marked this pull request as ready for review November 15, 2026 02:55
@devantler
devantler requested a review from a team as a code owner November 15, 2026 02:55
@devantler
devantler merged commit 3e0c088 into main Nov 15, 2026
30 checks passed
@devantler
devantler deleted the claude/match-template-script-mode branch November 15, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant