Repository navigation
fix(scripts): give the caller-pin contract the template's file mode - #481
Merged
Merged
Conversation
The template ships scripts/workflow-caller-pin-contract.test.sh as 100644 and this copy was 100755, so the template-sync merge stops on an add/add conflict for that path. Every caller runs it with sh, so it needs no executable bit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The first template-sync after onboarding (#480) stopped on one merge conflict:
scripts/workflow-caller-pin-contract.test.shis template-owned and identical in content here, but this copy is100755while the template ships100644. The sync merges the template's tree, and a mode-only difference on a file both sides add is an add/add conflict, which the sync workflow (now ondevantler-tech/.githubv21.6.2) correctly refuses to open a PR over (failed run).This drops the executable bit so the file matches the template. CI,
CONTRIBUTING.mdanddocs/REFERENCE.mdall run it assh scripts/workflow-caller-pin-contract.test.sh, so nothing depended on the bit.Validation
sh scripts/workflow-caller-pin-contract.test.shpasses.git merge-tree --allow-unrelated-historiesof this repository'smainwith the template'smainshows this file as the only conflict outside.templatesyncignore.🤖 Generated with Claude Code