Open
Conversation
* updating changes * Issue #34 resolved * Added cron-job : TrendUpdate News
salujajaskeerat
requested changes
Aug 2, 2021
Member
salujajaskeerat
left a comment
salujajaskeerat
left a comment
There was a problem hiding this comment.
Minor improvements in code style
src/models/user.ts
Outdated
| isAdmin: boolean; | ||
| isSuperAdmin: boolean; | ||
| roles: mongoose.Types.ObjectId[]; | ||
| permissions: UserPermImpl[]; //Local Permissions |
Member
There was a problem hiding this comment.
remove this it is storing redundant data, Instead, make a single function that takes user roles array and return the permissions out of it.
src/controllers/event.ts
Outdated
| if (event === null || user === null) { | ||
| throw createError(400, 'Invalid', 'No Such Event Exists'); | ||
| } | ||
| if (req.body.name !== null) { |
Member
There was a problem hiding this comment.
Fix The update method, the same can be done using a single command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private events implemented, Changed the interfaces EventImpl, BodyImpl and BodyMemberImpl and the corresponding schemas.
Modified getEvent and getEvents apis