Refactor tools API to Fastify TypeScript adapter by pasibun · Pull Request #76 · developer-overheid-nl/don-tools-api

pasibun · 2026-06-10T10:07:04Z

No description provided.

github-actions · 2026-06-10T10:08:58Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-10T10:17:43Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-10T12:04:59Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

- Updated package.json to change main entry point and scripts for NestJS. - Removed legacy Fastify app structure from app.ts, config.ts, error-handler.ts, routes.ts, server.ts, and operation-id.ts. - Introduced ToolsApiService to handle API logic using NestJS. - Updated TypeScript configuration for compatibility with NestJS. - Modified tests to work with the new NestJS application structure.

github-actions · 2026-06-11T08:03:15Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

- Changed the base URL in the OpenAPI specification from `https://api.don.projects.digilab.network/tools/v1` to `https://api.don.apps.digilab.network/tools/v1`. - Added custom operation handlers for various endpoints in the OpenAPI specification. - Introduced `api-implementations.ts` to define API implementations. - Created `api.module.ts` to manage dynamic module configuration for API implementations. - Implemented `ToolsApiService` to handle business logic for the Tools API. - Updated `ToolsApiController` to remove unnecessary HTTP code decorators. - Adjusted the main entry point in `package.json` and `tsconfig.json` to reflect the new structure. - Added tests to ensure the application works as expected with the new structure.

github-actions · 2026-06-12T09:38:27Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-16T11:53:43Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

…ckerfile

github-actions · 2026-06-16T12:44:18Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

…mline Dockerfile" This reverts commit 49935f8.

This reverts commit ddc2b42.

github-actions · 2026-06-16T12:49:30Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-16T15:51:18Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-16T15:53:43Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-16T16:10:32Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-16T16:18:49Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-16T16:28:01Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-16T16:42:01Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-24T09:42:12Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-24T11:31:10Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-24T11:32:09Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-24T11:56:07Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-24T22:01:20Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Copilot

Pull request overview

This PR migrates the Tools API v1 HTTP layer from the previous generated Express/JS implementation to a NestJS + Fastify + TypeScript adapter, delegating tool behavior to @developer-overheid-nl/don-tools-logic and introducing OpenAPI-driven request/response validation and mocking.

Changes:

Replace the Express server + in-repo service implementations with a NestJS/Fastify app and a ToolsApiService adapter that calls @developer-overheid-nl/don-tools-logic.
Add TypeScript + Vitest setup and new tests for HTTP behavior and OAS conversion.
Update Docker build/runtime stages and GitHub Actions workflows for the new toolchain (Node 22, build step, pinned actions).

Reviewed changes

Copilot reviewed 56 out of 58 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
vitest.config.ts	Adds Vitest configuration for the new TypeScript test suite.
utils/openapiRouter.js	Removes legacy Express OpenAPI routing middleware.
utils/fileName.js	Removes legacy filename sanitization utility (previously used by in-repo services).
tsconfig.json	Adds TypeScript compiler configuration for the new NestJS/TS codebase.
test/OasConversionService.test.js	Removes legacy Node test suite for conversion service.
test/convert-oas.test.ts	Adds Vitest coverage for conversion behavior via the logic package.
test/app.test.ts	Adds integration-style tests using Fastify inject against the Nest app.
services/ZipService.js	Removes legacy in-repo Zip service implementation.
services/ToolsService.js	Removes legacy in-repo ToolsService implementation.
services/Service.js	Removes legacy service response/mocking utilities used by generated code.
services/RemoteSpecificationService.js	Removes legacy remote fetch helper used by old validators/converters.
services/PostmanConversionService.js	Removes legacy Postman conversion implementation.
services/OasValidatorService.js	Removes legacy ADR validation implementation.
services/OasInputService.js	Removes legacy OAS input resolver.
services/OasGeneratorService.js	Removes legacy OpenAPI generator implementation.
services/OasConversionService.js	Removes legacy OpenAPI convert implementation.
services/OasBundleService.js	Removes legacy OpenAPI bundle implementation.
services/KeycloakService.js	Removes legacy Keycloak admin client implementation.
services/index.js	Removes legacy service export barrel.
services/ArazzoVisualizationService.js	Removes legacy Arazzo visualization implementation.
README.md	Rewrites README to describe the new NestJS/Fastify/TS architecture and workflows.
README 2.md	Removes old generated-server README content.
publiccode.yml	Updates stack description from Express/JS to TypeScript/Fastify.
package.json	Updates scripts/deps for NestJS/Fastify/TS/Vitest and logic-package integration.
models/untrust-client-input.ts	Adds generated model interface for untrust client input.
models/oas-input.ts	Adds generated model interface for OAS input.
models/models-lint-result.ts	Adds generated model interface for lint results.
models/models-lint-message.ts	Adds generated model interface for lint messages.
models/models-lint-message-info.ts	Adds generated model interface for lint message info items.
models/models-keycloak-client-result.ts	Adds generated model interface for Keycloak client creation response.
models/index.ts	Adds models barrel + global type declarations for generated model types.
logger.js	Removes legacy Winston logger setup used by the Express app.
index.js	Removes legacy Express entrypoint.
implementation/tools-api.service.ts	Adds Nest injectable adapter that calls `@developer-overheid-nl/don-tools-logic`.
expressServer.js	Removes legacy Express server implementation.
Dockerfile	Switches to multi-stage build producing `dist/` and runs Node 22 on port 1338.
decorators/index.ts	Adds decorator barrel exports.
decorators/headers-decorator.ts	Adds custom `@Headers` decorator workaround for Nest pipes on headers.
decorators/cookies-decorator.ts	Adds custom `@Cookies` decorator for cookie access (framework-dependent).
controllers/ToolsController.js	Removes legacy Express controller wrapper.
controllers/ToolsApi.controller.ts	Adds Nest controller mapping HTTP routes to the ToolsApi abstraction.
controllers/index.ts	Adds controllers barrel export for Nest module wiring.
controllers/index.js	Removes legacy controller export barrel (CommonJS).
controllers/Controller.js	Removes legacy generated controller request/response handler.
config.js	Removes legacy runtime config used by Express server.
biome.json	Updates Biome schema/version and includes TS/Nest directories in formatting/linting.
app/index.ts	Adds Nest/Fastify bootstrap with OpenAPIBackend validation, mocking, and optional response validation.
app/api.module.ts	Adds dynamic module to wire API implementations and default 501 proxies.
app/api-implementations.ts	Adds typing for API implementation injection.
api/ToolsApi.ts	Adds abstract Tools API contract used by controller + implementation.
api/openapi.yaml	Adds/updates OpenAPI spec file used at runtime for validation/mocking.
api/openapi.json	Updates OpenAPI JSON (server URL + operationId normalization metadata).
api/index.ts	Adds API barrel export.
.github/workflows/node-ci.yml	Updates CI to Node 22 and pins GitHub Actions by SHA.
.github/workflows/json-ci.yml	Pins actions by SHA for linting workflow.
.github/workflows/deploy-test.yml	Pins actions by SHA and updates yq install version/checksum.
.github/workflows/deploy-prod.yml	Pins actions by SHA and updates yq install version/checksum.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+{
+  "openapi": "3.0.1",
+  "info": {
+    "contact": {


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-06-25T06:40:43Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-25T07:29:56Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

github-actions · 2026-06-26T07:06:24Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

…loy-test]" This reverts commit f602d1f.

github-actions · 2026-06-26T09:32:54Z

Super-linter summary

Language	Validation result
JSON	Pass ✅
OPENAPI	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

dvh · 2026-07-02T21:15:56Z

@copilot resolve the merge conflicts in this pull request

Copilot · 2026-07-02T21:18:29Z

@copilot resolve the merge conflicts in this pull request

Done in d432465.

Refactor tools API to Fastify TypeScript adapter

4e0230f

pasibun linked an issue Jun 10, 2026 that may be closed by this pull request

tools-api refactor #60

Closed

Update API dependencies

d7581eb

Use tools logic package from git

613244f

Fix GitHub dependency installs in CI

ddc2b42

refactor: update Git configuration for HTTPS access and streamline Do…

49935f8

…ckerfile

pasibun added 2 commits June 16, 2026 14:47

Revert "refactor: update Git configuration for HTTPS access and strea…

89eff1b

…mline Dockerfile" This reverts commit 49935f8.

Revert "Fix GitHub dependency installs in CI"

5ff9c55

This reverts commit ddc2b42.

new version

bfd6718

Improve Tools API v1 README

c543436

refactor: update dependency for don-tools-logic to version 0.0.1

cc3ab8b

Implement feature X to enhance user experience and optimize performance

f19c5fa

Fix npm ci lockfile entries

6ba9d53

chore: trigger test deploy [deploy-test]

51e31b2

pasibun added 2 commits June 24, 2026 13:29

fix: update don-tools-logic dependency to version 0.0.2

c52cae5

chore: trigger test deploy [deploy-test]

0076a41

Fix npm 10 Docker lockfile sync [deploy-test]

9870ae9

dvh requested changes Jun 24, 2026

View reviewed changes

Comment thread api/ToolsApi.ts Outdated

Apply Biome to generated API files [deploy-test]

91b26ec

dvh requested a review from Copilot June 25, 2026 06:09

dvh previously approved these changes Jun 25, 2026

View reviewed changes

Copilot started reviewing on behalf of dvh June 25, 2026 06:09 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread app/index.ts

Comment thread app/index.ts Outdated

Comment thread api/openapi.yaml Outdated

Comment on lines +1 to +4

{

"openapi": "3.0.1",

"info": {

"contact": {

Comment thread implementation/tools-api.service.ts

Comment thread test/convert-oas.test.ts

Apply suggestions from code review

4a51a39

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

pasibun dismissed dvh’s stale review via 4a51a39 June 25, 2026 06:38

Remove redundant OpenAPI YAML [deploy-test]

bc2bdf5

Use fixed DON tools package for circular OAS dereference [deploy-test]

f602d1f

Revert "Use fixed DON tools package for circular OAS dereference [dep…

2b1a517

…loy-test]" This reverts commit f602d1f.

dvh enabled auto-merge July 2, 2026 21:15

Copilot started work on behalf of dvh July 2, 2026 21:16 View session

Merge origin/main into 60-tools-api-refactor

d432465

Copilot finished work on behalf of dvh July 2, 2026 21:18

Copilot AI requested a review from dvh July 2, 2026 21:18

Uh oh!

Conversation

pasibun commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 10, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 10, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 11, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 12, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 16, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 16, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 16, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 16, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 16, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 16, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 16, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 16, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 16, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 24, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 24, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 24, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 24, 2026

Super-linter summary

Uh oh!

Uh oh!

github-actions Bot commented Jun 24, 2026

Super-linter summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 25, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Jun 26, 2026

Super-linter summary

Uh oh!