feat!: reconcile deleted tools and helper script#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our deployment is upsert only, if a new tool is added it's deployed and current tools are updated if touched. (Index service also updates when new ones added)
What doesn't happen is if we remove a toolset, we leave it deployed indefinitely till we manually clean up.
This PR adds a
remove-toolset(opposite effects ofnew-toolset) and areconcilestep indeploy.yamlthat lists the mcps' deployed and if they don't match the ones in thetoolsetsdirectory, it deletes extra ones.