feat!: remove dummy dataset search (testing reconcile pipeline)#7
Merged
Conversation
ciaransweet
force-pushed
the
remove-hardcoded-dataset-search
branch
from
June 12, 2026 13:14
cbc4d08 to
c85b23f
Compare
yellowcap
approved these changes
Jun 16, 2026
| echo "Not removed automatically: out-of-band Secrets the toolset listed in" | ||
| echo "toolset.yaml, and its images in GHCR." | ||
|
|
||
| # Other code or docs may still reference the toolset (README examples, tests |
Member
There was a problem hiding this comment.
Not sure if everyone will remember running this when removing a tool. But its ok to have it.
Contributor
Author
There was a problem hiding this comment.
Yeah, the block below searches for references that weren't deleted and tells the invoker that 🫡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the reconcile login by running
scripts/remove-toolset dataset-search