Repository navigation
fix(hub-ui): prevent hidden dock elements from receiving input - #492
Merged
antfu merged 4 commits intoNov 18, 2026
Merged
Conversation
|
@tonoizer is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
|
👁️🗨️ Review this pull request with grouped, summarized diffs at: raw result💭 analyzed by {
"headSha": "4cc85a0224b355eec4484312875242ee1a26a63a",
"result": {
"overallSummary": "This PR fixes an accessibility/input-handling bug in the embedded floating dock: the fading brand-mark decoration could still receive pointer hits, and minimized control wrappers stayed reachable by screen readers and keyboard focus. It also keeps the dock expanded while a control is focused, and adds Playwright e2e regression tests against the real custom element to lock in the fix. An unrelated `prepare` script tweak was carried over from a merged branch.",
"groups": [
{
"key": "dock-fix",
"label": "Dock input/focus fix",
"summary": "Fixes the floating dock so decorative elements no longer intercept pointer input, minimized controls are removed from the accessibility tree and tab order via `inert`/`aria-hidden`, and the dock stays expanded while a control holds keyboard focus instead of collapsing from inactivity.",
"category": "ui",
"filePaths": [
"packages/hub-ui/src/client/components/dock/Dock.vue"
],
"critical": true,
"fileNotes": [
{
"path": "packages/hub-ui/src/client/components/dock/Dock.vue",
"text": "Adds `pointer-events-none`/`aria-hidden` to the decorative brand mark, `inert`/`aria-hidden` to the minimized control wrappers, and keeps `isMinimized` false while the dock has focus within it.",
"critical": true
}
]
},
{
"key": "dock-e2e-tests",
"label": "Dock e2e regression tests",
"summary": "Adds Playwright browser tests exercising the real embedded dock (centered-click hit testing, shadow-root hit stack, hidden/minimized controls, tab order, focus retention through inactivity, hover restoration, and dragging), plus a small fixture app/page serving it; the knip entry list is updated so the fixture script isn't flagged as unused.",
"category": "tests",
"filePaths": [
"tests/e2e/floating-dock.spec.ts",
"tests/e2e/_support/floating-dock/index.html",
"tests/e2e/_support/floating-dock/main.ts",
"knip.jsonc"
],
"fileNotes": [
{
"path": "tests/e2e/floating-dock.spec.ts",
"text": "Uses a temporary Vite dev server plus Playwright's clock to simulate the inactivity timeout and verifies behavior across both trusted and unauthorized, horizontal and vertical dock configurations."
}
]
},
{
"key": "chore-build",
"label": "Build/package chores",
"summary": "Unrelated chore carried over from a merge: runs `simple-git-hooks` directly in the `prepare` script instead of via `npx`.",
"category": "build",
"filePaths": [
"package.json"
],
"critical": false
}
],
"schemaVersion": 1,
"source": "llm",
"generatedAt": "2026-11-18T00:41:47.246Z",
"model": "vercel-ai-gateway/anthropic/claude-sonnet-5",
"locale": "en"
}
} |
SaKaNa-Y
approved these changes
Nov 16, 2026
npx on Node 27 for Windows resolves the bin from the wrong path. pnpm already puts node_modules/.bin on PATH for scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The embedded floating dock fades its centered brand mark with opacity, which leaves the decoration eligible for pointer hit testing. Its minimized control wrappers also remain exposed to accessibility queries and keyboard focus after pointer events are disabled.
Testing
pnpm lintpnpm knippnpm test --run: 1,847 passed, 26 skipped; no type errorspnpm typecheck: 43 tasks passedpnpm build: 29 tasks passedpnpm exec playwright test --workers=4: all 31 Chromium tests passedValidation ran on Windows with Node 24.19.0 and the repository's pnpm 12.18.0. The unit suite used a temporary directory outside the user-home tree so package-manager detection in the existing onboarding tests did not inherit a home-level Yarn configuration.
Risks
Runtime browser coverage is Chromium-only. The focused fixture exercises the shared embedded dock directly; it does not add separate React and Vue application fixtures. Existing opacity transitions, hover reveal, and dragging remain covered.