feat: cria pagina de login issue #240#301
Open
EdiltonOliveira wants to merge 1 commit intodevhatt:mainfrom
Open
feat: cria pagina de login issue #240#301EdiltonOliveira wants to merge 1 commit intodevhatt:mainfrom
EdiltonOliveira wants to merge 1 commit intodevhatt:mainfrom
Conversation
EdiltonOliveira
requested review from
DominMFD,
Frompaje,
JpBurgarelli,
Luiginicoletti,
PiluVitu and
juliaam
diogocaronte
requested changes
Sep 6, 2024
Contributor
diogocaronte
left a comment
diogocaronte
left a comment
There was a problem hiding this comment.
Está faltando mobile, e criar a rota para o login (o caminho dos arquivos ira mudar tambem)
| align-items: center; | ||
| } | ||
|
|
||
| .login-page__img-box img { |
Comment on lines
+7
to
+25
| const html = ` | ||
| <div data-select="container" class="login-page"> | ||
| <div class="login-page__img-box"> | ||
| <div class="login-page__img-top"> | ||
| <img src="${petdexLogo}" class="login-page__img-logopetdex"/> | ||
| </div> | ||
| <div class="login-page__img-down"> | ||
| <img src="${petAndDog}" class="login-page__img-petanddog"/> | ||
| </div> | ||
|
|
||
| </div> | ||
| <div class=login-page__login-box> | ||
|
|
||
| <div class="login-page__login-form"> | ||
| </div> | ||
| </div> | ||
|
|
||
| </div> | ||
| `; |
Contributor
Author
Design figma para a tela de login indisponível. Sendo assim, tenho a liberdade de poder criar a versão mobile ? |
Frompaje
suggested changes
Sep 9, 2024
Comment on lines
+9
to
+14
| <div class="login-page__img-box"> | ||
| <div class="login-page__img-top"> | ||
| <img src="${petdexLogo}" class="login-page__img-logopetdex"/> | ||
| </div> | ||
| <div class="login-page__img-down"> | ||
| <img src="${petAndDog}" class="login-page__img-petanddog"/> |
Contributor
There was a problem hiding this comment.
bota o kebab no logo-petdex
ex:
class="login-page__img-logo-petdex| @@ -0,0 +1,34 @@ | |||
| import { Component } from 'pet-dex-utilities'; | |||
| import LoginForm from '../../../../components/LoginForm'; | |||
Contributor
There was a problem hiding this comment.
Não dava para usar o Path Aliases aqui?
|
|
||
| </div> | ||
| <div class=login-page__login-box> | ||
|
|
Member
There was a problem hiding this comment.
ta sem eslint configurado? pq acho que ele ja evita esses espacos e ajusta a identacao, qualquer duvida liga nois pra configurar.
juliaam
approved these changes
Oct 2, 2024
Contributor
|
atualiza a branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #240
Feature
N/A
Bugfix
Description
N/A
Cause
N/A
Solution
N/A
Changelog
Visual evidences 🖼️
Checklist
Additional info
N/A