Replace separate lint step with comprehensive quality checks in CI#29
Merged
Merged
Conversation
pjurczynski
force-pushed
the
feature/ci-quality-integration
branch
from
July 9, 2025 11:30
9fab335 to
8e4da3d
Compare
pjurczynski
marked this pull request as draft
July 9, 2025 11:41
The quality script already includes linting along with other comprehensive code quality checks (complexity, duplication, code smells, etc.), so the separate lint step is redundant. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
pjurczynski
force-pushed
the
feature/ci-quality-integration
branch
from
July 9, 2025 22:08
8e4da3d to
34a1f46
Compare
GitHub Actions uses shallow clones by default (fetch-depth: 1) which only fetches the latest commit. Our quality check script uses `git diff --name-only HEAD~1 HEAD` to identify changed files in push events, but HEAD~1 doesn't exist in a shallow clone with only one commit. Setting fetch-depth: 2 ensures that both HEAD and HEAD~1 are available, allowing the script to compare the current commit with its parent to determine which TypeScript files have changed and need quality checking. This prevents the "fatal: bad object [SHA]" error that occurs when the script tries to reference HEAD~1 in a shallow clone environment. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
|
#33 confirms that errors are caught as expected. |
pjurczynski
marked this pull request as ready for review
July 9, 2025 22:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
.github/workflows/ci.ymlto usenpm run qualityinstead ofnpm run lintBenefits
Quality Checks Included
Test Plan
🤖 Generated with Claude Code