compiler: Enhance IR to support more advanced parlang (CUDA/HIP/SYCL) features#2822
Closed
FabioLuporini wants to merge 21 commits intomainfrom
Closed
compiler: Enhance IR to support more advanced parlang (CUDA/HIP/SYCL) features#2822FabioLuporini wants to merge 21 commits intomainfrom
FabioLuporini wants to merge 21 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2822 +/- ##
=======================================
Coverage 83.02% 83.02%
=======================================
Files 248 248
Lines 51075 51168 +93
Branches 4492 4499 +7
=======================================
+ Hits 42403 42484 +81
- Misses 7901 7910 +9
- Partials 771 774 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FabioLuporini
force-pushed
the
tma-inception-ny
branch
from
6a6feb1 to
d1d4020
Compare
EdCaunt
reviewed
Jan 8, 2026
| def __hash__(self): | ||
| return hash((super().__hash__(), self.sub_iterators, | ||
| self.directions)) | ||
| return hash((super().__hash__(), self.sub_iterators, self.directions)) |
Contributor
There was a problem hiding this comment.
Would it be worth having a _hashable_content attached to Space with a
def __hash__(self):
return hash((type(self).__name__,) + tuple(getattr(i) for i in self._hashable_content))and extending _hashable_content with each subclass?
I think it might improve concision, maintainability, and readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
99% of this has already been reviewed in #2748, but I prefer to open a new one so that the branch names across OSS and PRO match up , since the PRO PR is huge
This one has also been rebased on latest
main