fix(map): split the region counter into appellations vs DGCs; re-home… - #22
Merged
Merged
Conversation
… Forez + Lyonnais The appellation facet counted a region's appellations and their complementary geographic designations as one number, implying a legal precision it doesn't have: Burgundy read 871 where the regulator recognises 84 appellations (7 régionales + 44 villages + 33 grands crus) carrying 785 complementary designations — premier-cru climats, Bourgogne Côte d'Or, Mâcon-Azé and the like. Reported by Reinier Broeks (Winecastr) while researching an article. The count now renders as "84 +785" with a per-locale tooltip naming both tiers, falling back to a bare number where a region has no sub-denominations. Formatting lives in one helper because the count is written twice: once on the initial paint and again by refreshFacetVisibility on every filter change — the refresh path previously overwrote the split with a plain filtered total, so the tooltip and the visible number disagreed. is_sub_denomination joins STARTUP_AOCS_FIELDS: buildAppellationFacet now reads it, and a field read on a startup path but absent from that set silently degrades the sidebar (every record looks like a parent). Separately, two BOURGOGNE-bassin appellations are not in Burgundy. INAO's comité régional is an administrative grouping: Côtes du Forez sits in the upper Loire beside Côte roannaise and Côtes d'Auvergne, which INAO itself files under VAL DE LOIRE, and Coteaux du Lyonnais continues the Beaujolais granite south of Lyon. Both move, alongside the existing JURA/SAVOIE/BUGEY/BEAUJOLAIS splits. Verified against a local build: 2908 records, 20 countries, Burgundy 84+785, Beaujolais 12+31, Piemonte flat at 59. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`_lib.ch.canton` sat after `_lib.ch.geometry`, which trips the I001 import-sorting rule CI pins at zero. Pre-existing on main — the branch inherited the red build rather than causing it. Pure reordering of two adjacent imports in the same group; no behaviour change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Forez + Lyonnais
The appellation facet counted a region's appellations and their complementary geographic designations as one number, implying a legal precision it doesn't have: Burgundy read 871 where the regulator recognises 84 appellations (7 régionales + 44 villages + 33 grands crus) carrying 785 complementary designations — premier-cru climats, Bourgogne Côte d'Or, Mâcon-Azé and the like. Reported by Reinier Broeks (Winecastr) while researching an article.
The count now renders as "84 +785" with a per-locale tooltip naming both tiers, falling back to a bare number where a region has no sub-denominations. Formatting lives in one helper because the count is written twice: once on the initial paint and again by refreshFacetVisibility on every filter change — the refresh path previously overwrote the split with a plain filtered total, so the tooltip and the visible number disagreed.
is_sub_denomination joins STARTUP_AOCS_FIELDS: buildAppellationFacet now reads it, and a field read on a startup path but absent from that set silently degrades the sidebar (every record looks like a parent).
Separately, two BOURGOGNE-bassin appellations are not in Burgundy. INAO's comité régional is an administrative grouping: Côtes du Forez sits in the upper Loire beside Côte roannaise and Côtes d'Auvergne, which INAO itself files under VAL DE LOIRE, and Coteaux du Lyonnais continues the Beaujolais granite south of Lyon. Both move, alongside the existing JURA/SAVOIE/BUGEY/BEAUJOLAIS splits.
Verified against a local build: 2908 records, 20 countries, Burgundy 84+785, Beaujolais 12+31, Piemonte flat at 59.