Repository navigation
feat(release): add Store, Homebrew, and WinGet installation channels - #143
Merged
Merged
Conversation
The Store requires that a product it installed update only through the Store, so a Store build must never run qrate's own updater. MSI installs already declare exactly this, because an administrator owns them. Widening `self_managed()` to cover the Store is therefore the whole change: `find_installation`'s marker check and `AutoUpdater::poll` both already read it, so no new control flow appears. The exhaustive apply match gains the arm it now requires. `initial_status` needs its own arm rather than sharing the MSI one — that text tells the reader to contact their administrator, which is not who manages an install somebody chose from the Store. The kebab-case wire string is pinned by a test because the MSIX manifest and the install marker have to agree on it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo fmt --all --checkpassed.cargo clippy --workspace --all-targets -- -D warnings -A dead_codepassed.cargo test --workspacewas interrupted at the user's request; the PR CI will run the full matrix.Closes #136 (Notion ID: 3e121d32-b13b-815e-a15d-dce60c580537)
Refs #137 (Notion ID: 3e121d32-b13b-8135-863d-ec465e5d4adc)