Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a repair migration to make upgrades from an older workspace schema safe by backfilling legacy workspaces rows into connection_workspaces and (for Surreal) syncing the id sequence so new workspace inserts don’t collide.
Changes:
- Add a repair migration that creates
connection_workspacesif missing, backfills from legacyworkspaces, and updates the Surreal sequence. - Add a feature test that simulates the legacy schema and asserts the backfill populates
connection_workspaces.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
database/migrations/2026_03_27_135040_repair_connection_workspaces_table.php |
Creates/backfills connection_workspaces from legacy workspaces and attempts to sync Surreal sequence. |
tests/Feature/WorkspaceManagementTest.php |
Adds regression coverage for the legacy-to-new backfill behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
database/migrations/2026_03_27_135040_repair_connection_workspaces_table.php
Show resolved
Hide resolved
database/migrations/2026_03_27_135040_repair_connection_workspaces_table.php
Outdated
Show resolved
Hide resolved
database/migrations/2026_03_27_135040_repair_connection_workspaces_table.php
Outdated
Show resolved
Hide resolved
database/migrations/2026_03_27_135040_repair_connection_workspaces_table.php
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connection_workspacesTesting
Fixes #140