feat(diagnostics): add owner-only pane evidence - #137
Merged
Conversation
Amend the P2 RFC to rev.4 with normative section 4.1.2, the approved contract prerequisite for pane diagnostics. It permits a separate owner-only, no-store, read-only GET /api/settings/diagnostics/panes projection built only from cached collector rows and the last completed host snapshot, publishing sample-local display ordinals, validated tmux coordinates and PIDs, and closed allowlisted outcomes. Raw socket paths/names, session names, cwd, argv, provider-session IDs, transcript data, process start times, configuration and filesystem evidence, and exception text stay server-private, and the projection carries no new action authority under the existing N1-N3 rules. Collector and host sample ages stay independent, output is bounded with explicit omission counts, missing evidence surfaces as unknown, and the aggregate diagnostics response is unchanged. TMUX-DISCOVERY documents the same single exception to its privacy boundary. The roadmap checkbox stays open. Validation: pure prose with no machine consumer, so QA is by read. Re-read the full diff, confirmed the existing normative rules (N4, B17a, 4.1.1) remain consistent with the single scoped exception, and git diff --check exits 0. Co-authored-by: OmO <omo@users.noreply.github.com>
Append the five approved display-only pane diagnostics types without changing the existing aggregate or adding runtime behavior. Validation: shared diagnostics LSP clean; npm run typecheck and git diff --check exit 0. Co-authored-by: OmO <omo@users.noreply.github.com>
Add a synchronous peek and a narrow provider getter for the existing shared snapshot source. Preserve capture reuse, failure evidence, cancellation checks and inventory serialization. Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
Project cached collector and host observations into an owner-only GET response with sample-local labels, strict redaction and bounded PID ancestry. Keep aggregate diagnostics and discovery/control behavior unchanged. Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent)\n\nCo-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
Settle cached diagnostics reads independently while making owner denial clear both sections. Expose pane-scoped states and complete localized sample, capture, identity, process, lineage, and coverage evidence without actions. Cover endpoint failures, cancellation and late response races with deterministic mounted regressions and typed fixtures. Preserve the aggregate contract. Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
Extend the existing real fixture matrix with local pane projection checks, independently fulfilled endpoint failures, state and field assertions, and English/Korean keyboard and responsive evidence. Preserve existing English feature cases and required artifacts. Verify meaningful state, isolation, and omission-count mutation REDs, then the complete six-case browser GREEN with owned-resource cleanup. Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/settings/diagnostics/panesprojection over cached discovery and host evidence.Verification
npm run verify: passed, including 2,507 repository tests, audit, TypeScript, Rust, lint, identity and production build.npm run cua:improvementsagainst the real isolated hub/two-peer fixture: all 6 cases passed at 1440x1000, 320x568 and 390x844, including 210 keyboard refresh actions and 147 PNG captures.Reproduction is documented in
scripts/cua/README.md. The local review bundle contains browser action records, screenshots, HTTP responses and cleanup receipts. Browser emulation is not physical-phone, native-desktop or Tailscale-network evidence.Ultraworked with omo