Skip to content

Convert to SDK style project and update dependencies#22

Open
ericstj wants to merge 1 commit into
devtrends:masterfrom
ericstj:updateSdkStyleAndDependencies
Open

Convert to SDK style project and update dependencies#22
ericstj wants to merge 1 commit into
devtrends:masterfrom
ericstj:updateSdkStyleAndDependencies

Conversation

@ericstj

@ericstj ericstj commented Oct 10, 2025

Copy link
Copy Markdown

I commented in #21 about how just updating newtonsoft wasn't the correct thing, so I thought I'd give a try at updating this project myself.

I converted to SDK style and retained the same package structure (probably it could be modernized to use ContentFiles, but I'm not super familiar with that).

I also made it do public signing - which is "fake signing" with just an exported public key. If you were to accept this change and you have the real keypair, you'd want to make sure you build and override the two properties /p:AssemblyOriginatorKeyFile=<pathToRealSNK> /p:PublicSign=false

@ericstj

ericstj commented Nov 25, 2025

Copy link
Copy Markdown
Author

@devtrends would it be possible to consider this - or a smaller version of it if you prefer? Updating the dependency on Microsoft.AspNet.WebApi.Core will help folks avoid CVE alerts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant