Add helper function for setting cornerRadius#177
Open
cozzin wants to merge 1 commit intodevxoul:masterfrom
Open
Add helper function for setting cornerRadius#177cozzin wants to merge 1 commit intodevxoul:masterfrom
cozzin wants to merge 1 commit intodevxoul:masterfrom
Conversation
devxoul
approved these changes
Sep 7, 2019
Owner
devxoul
left a comment
There was a problem hiding this comment.
I think this can be a good alternative solution.
Collaborator
|
I'm not a fan of this. In case of ambiguity, there is certainly a way to specify which method is the desired one. And solving the ambiguity for calling our method will not solve the ambiguity when you want to call the UIView method. It's better to remove |
Contributor
Author
|
@Coeur I know you want to make I tested like this: ToastView.appearacne().backgroundView.layer.cornerRadius = 20Or did you mean like this code? ToastView.appearacne().backgroundView = CustomBackgroundView() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #113
Just add a setter for
cornerRadius.Actually, I have tried to make public backgroundView, but it does not work.