Skip to content

Fix Stage Manager window slide when closing popover - #93

Merged
devxoul merged 1 commit into
devxoul:mainfrom
noah30000:fix/stage-manager-popover
Jun 15, 2026
Merged

Fix Stage Manager window slide when closing popover#93
devxoul merged 1 commit into
devxoul:mainfrom
noah30000:fix/stage-manager-popover

Conversation

@noah30000

@noah30000 noah30000 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Problem

When closing the Allkdic popover with the hotkey, windows from other
apps (e.g. Chrome) slide to the side stage in Stage Manager. This is
caused by NSApp.activate(ignoringOtherApps: true) in openPopover(),
which triggers Stage Manager to treat the app activation as a scene
switch. When the popover is then closed, Stage Manager animates the
transition back, making other windows appear to slide sideways.

Solution

Removed NSApp.activate(ignoringOtherApps:) from openPopover().
NSPopover shown relative to a status bar button works correctly without
activating the app, and Stage Manager no longer slides other windows.

Testing

Tested with Stage Manager enabled on macOS 26.5. Chrome no longer
slides when opening/closing the Allkdic popover.


Summary by cubic

Prevent Stage Manager from sliding other app windows when toggling the Allkdic status bar popover. Removed NSApp.activate(ignoringOtherApps: true) from openPopover() so showing the popover doesn’t trigger a scene switch.

Written for commit 0746a14. Summary will update on new commits.

Review in cubic

Removed NSApp.activate(ignoringOtherApps:) from openPopover() as it
caused Stage Manager to treat the app activation as a scene switch,
making Chrome and other windows slide to the side stage when the
popover is closed.
@typeey

typeey Bot commented Jun 14, 2026

Copy link
Copy Markdown

Thanks for the clear write-up and Stage Manager-specific test notes. The root cause makes sense: avoiding foreground app activation for a status-item popover should prevent Stage Manager from treating it like a scene switch. If you want a full code review pass from me, request my review and I’ll run through the diff properly. (。•̀ᴗ-)✧

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@devxoul

devxoul commented Jun 14, 2026

Copy link
Copy Markdown
Owner

@typeey can you review if this can lead a side effect or any regressions

@typeey typeey Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable side-effect or regression risk found in this change. The removed activation was only on the popover-open path; the code still explicitly activates when opening real Preferences/About windows, while status-item clicks, the Carbon global hotkey, transient popover dismissal, and the existing focus notification path remain intact.

@devxoul
devxoul merged commit 992dc58 into devxoul:main Jun 15, 2026
2 checks passed
@devxoul

devxoul commented Jun 15, 2026

Copy link
Copy Markdown
Owner

Thanks so much for this, @noah30000! 🙏 The diagnosis was spot-on — pinpointing NSApp.activate(ignoringOtherApps:) as the Stage Manager trigger, plus the clear write-up and testing notes, made this a breeze to review and merge.

This is bundled into 2.2.3, which is currently in App Store review — it'll go live automatically once Apple approves. Really appreciate the contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants