Repository navigation
Conversation
ruff format replaces black (including notebooks), and ruff check replaces flake8, configured with the same checks (pycodestyle and pyflakes, 88-character lines). docformatter and pyright are unchanged. The only code change is how ruff formats one assert statement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff formatreplaces black, including for the notebooks, andruff checkreplaces flake8.E,W) and pyflakes (F), with an 88-character line limit..hatchand.vscodeare excluded automatically..condaisn't gitignored, so it's excluded explicitly, as it was for flake8..flake8is deleted, and its settings move to[tool.ruff]inpyproject.toml.Code changes
ruff formatagrees with black everywhere except oneassertinbdms/tree.py, which it wraps differently.ruff checkfinds nothing.Not included
With no
selectsetting, ruff 0.17's default rules are broader than flake8's, and they report 27 findings on this code. Most are style, such as import order. Two are worth knowing about:InhomogeneousProcessuses mutable dict defaults forquad_kwargsandroot_kwargs, so all instances share the same dicts. Nothing in BDMS modifies them. Any of these rules can be turned on later by adding them toselect.Testing
In a fresh clone with Python 3.14, I ran
hatch env createand then each hatch script.hatch run lintpasses,hatch run formatchanges nothing, andhatch run testspasses, covering unit tests, doctests, and both notebooks.hatch run docsbuilds with only the three warnings that were already there. I also checked that a lint error inside.conda/isn't reported.🤖 Generated with Claude Code