Skip to content

Class3 tic tac toe#7

Open
deytonk wants to merge 13 commits intogh-pagesfrom
class3-ticTacToe
Open

Class3 tic tac toe#7
deytonk wants to merge 13 commits intogh-pagesfrom
class3-ticTacToe

Conversation

@deytonk
Copy link
Owner

@deytonk deytonk commented Oct 24, 2017

Checkpoint Rubric

This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.

Checkpoint 1

  • All tests passed: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript: 30 points

Checkpoint 2

  • The application works as it should: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript and the DOM API: 30 points

Checkpoint 3

  • Use of React: 25 points
  • Accesses an API: 25 points
  • Proper use of documentation (commenting on code): 25 points
  • The application functions as it should: 25 points

Copy link

@reneemeyer reneemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on the right track, uncomment all of your code, and get it to work! Your logic is sound.

// call printBoard after every turn (push playerTurn to array


// if (checkForWin() = false) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this commented out?




// const validValue = (myIndex) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be un commented and moved to an outside function. Your logic is spot on, check for valid move, then the win, then switch the player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants