Repository navigation
Conversation
AGENTS.md and CONTRIBUTING.md state the rule; the remaining inline field initializers in core, tools, tests and the JMH benchmarks move into constructors. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.md(mirrored inCONTRIBUTING.md): every non-static field is initialized in the constructor, never at its declaration or in an instance initializer;static finalconstants are unaffected, and a field with no meaningful value yet is left unassigned. An object's whole state and build order then read in one place, and a constructor that must call something last (childOf(...)) can see every field is assigned.NativeObject,NativeObjectChild,NativeDB,PerfContext,PlainTableOptions,ReadOptions,RocksIterator,UpcallRegistry(new package-private constructor),JfrEventNotifier,SstDumpTool.Request, the anonymous iterators inLiveFiles/LiveFilesStorageInfo(int ikeeps its default),CloseFromAnotherThreadTestand the three JMH benchmark classes.ExplicitInitializationonly catches default values, so this stays a convention for now.Test plan
./mvnw test(all modules)🤖 Generated with Claude Code