chore(fbs): flatten schema dir to core/src/main/fbs#150
Merged
Conversation
The four .fbs schemas sat one-per-subdir under src/main/flatbuffers/ (vortex-array/, vortex-dtype/, vortex-file/, vortex-layout/), mirroring the Rust reference's crate layout. The in-house generator reads only the explicit file paths passed on the command line into one global type registry — the `include "..."` directives are recorded but never resolved from disk — so the nesting carried no build meaning. Flatten all four into a single directory and rename it to `fbs/`, matching the flat `src/main/proto/` siblings: src/main/flatbuffers/vortex-array/array.fbs -> src/main/fbs/array.fbs src/main/flatbuffers/vortex-dtype/dtype.fbs -> src/main/fbs/dtype.fbs src/main/flatbuffers/vortex-file/footer.fbs -> src/main/fbs/footer.fbs src/main/flatbuffers/vortex-layout/layout.fbs -> src/main/fbs/layout.fbs footer.fbs's include strings updated to the flat names, the regenerate-sources exec args and the fbs-gen parser/codegen tests repointed. Regenerated output is byte-identical — this is a pure source-tree move. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four
.fbsschemas each lived in their own subdir undersrc/main/flatbuffers/(vortex-array/,vortex-dtype/,vortex-file/,vortex-layout/), mirroring the Rust reference's crate layout.The in-house generator reads only the explicit file paths passed on the command line into one global type registry —
include "..."is parsed but never resolved from disk (MainjustFiles.readStrings each arg) — so the nesting carried no build meaning.Change
Flatten + rename to
fbs/, symmetric with the flatsrc/main/proto/siblings:flatbuffers/vortex-array/array.fbsfbs/array.fbsflatbuffers/vortex-dtype/dtype.fbsfbs/dtype.fbsflatbuffers/vortex-file/footer.fbsfbs/footer.fbsflatbuffers/vortex-layout/layout.fbsfbs/layout.fbsfooter.fbsinclude strings →"array.fbs"/"layout.fbs"regenerate-sourcesexec args +fbs-genParserTest/CodeGenTestpaths repointed🤖 Generated with Claude Code