feat(jpms): add module-info for core/reader/writer [WIP]#176
Draft
dfa1 wants to merge 1 commit into
Draft
Conversation
Adds JPMS descriptors to the three published library modules now that the in-house fbs/proto toolchain removed the flatbuffers-java split-package blocker (ADR 0017). State: - core: modular, builds clean, 359 tests green. Exports model/error/io; compute and the generated fbs/proto codecs qualified-exported to reader/writer. requires static java.compiler (SOURCE-retention @generated on proto records). - reader: modular, builds clean, 857 tests green. requires transitive core + java.net.http (HttpClient in public API); requires static zstd (optional, automatic module). uses/provides EncodingDecoder. - writer: main modular, builds clean. requires transitive core; requires static zstd. uses/provides EncodingEncoder + ExtensionEncoder. Does NOT require reader (architectural rule preserved). Narrow @SuppressWarnings("exports") on ArrayStats.fromFbs and VariantData: both are intentional public entry points that take a generated wire type core only qualified-exports. Module name lint suppressed for the group-derived terminal digit (dfa1) and the zstd automatic module. KNOWN-INCOMPLETE: writer test sourceset fails under -Werror. Writer tests decode-verify round-trips via test-scope reader types, but tests patch into the writer module which (correctly) does not require reader. Added testCompile --add-reads=ALL-MODULE-PATH + surefire useModulePath=false, still resolving a residual exports/reads lint warning. Downstream modules (calcite/cli/etc.) are left non-modular and consume these as automatic modules via the classpath. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft / WIP — parking in-progress JPMS adoption. Do not merge yet.
Adds
module-info.javato the three published library modules, now unblocked by the in-house fbs/proto toolchain (ADR 0017 removed the flatbuffers-java split package).Done & green
model/error/io;compute+ generatedfbs/protocodecs qualified-exported to reader/writer.requires static java.compiler(SOURCE-retention@Generatedon proto records).requires transitive core+java.net.http(HttpClient is public API);requires static zstd(optional, automatic module).uses/provides EncodingDecoder.requires transitive core;requires static zstd.uses/provides EncodingEncoder+ExtensionEncoder. Does not require reader (architecture rule preserved).Narrow
@SuppressWarnings("exports")onArrayStats.fromFbsandVariantData— both are intentional public entry points taking a generated wire type that core only qualified-exports. Module-name lint suppressed for the group-derived terminal digit (dfa1) and the zstd automatic module.Known-incomplete (the blocker)
Writer test sourceset fails under
-Werror. Writer tests decode-verify round-trips using test-scope reader types, but they patch into thewritermodule which correctly does notrequirereader. AddedtestCompile --add-reads=ALL-MODULE-PATH+ surefireuseModulePath=false; a residual exports/reads lint warning remains. Needs a clean way to let the test module read reader without polluting the main module graph.Notes
zstddependency resolves as an automatic module namedzstd; the platform-native classifier jars derive invalid module names — fine on the classpath, but a future hazard if anything forces them onto the module path. Long-term fix: addAutomatic-Module-Nameto the zstd artifacts.🤖 Generated with Claude Code