chore: clear IntelliJ inspection warnings (zstd module)#18
Merged
Conversation
- ZstdException: annotate serialVersionUID with @serial - ZstdInputStream: inCap is constructor-only now, make it a local - ZstdStreamBuffer: drop the set() pos parameter (always 0); set pos internally and update the stream call sites - ZstdSkippableContent: use a record pattern in equals; suppress the IntelliJ @NotNull-override advisory on toString (never returns null, and we don't pull in the JetBrains annotations) - ZstdFrame: the five zero-copy MemorySegment overloads had no caller — cover them with a SegmentOverloads test that checks each mirrors its byte[] counterpart Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swept all 27
zstdmain-source files with IntelliJ inspections; cleared every warning.serialVersionUIDannotated@Serial.inCapis constructor-only after the earlier leak-fix refactor; demote the field to a local.set(buffer, size, pos)was always called withpos = 0; drop the parameter, set pos internally, update the stream call sites.equals; suppress the@NotNull-override advisory ontoString(never returns null; project deliberately avoids the JetBrains annotations dependency).MemorySegmentframe-inspection overloads had no caller (the project's segment-first surface). Rather than drop public API, add aSegmentOverloadstest asserting each mirrors itsbyte[]counterpart — silences the "never used" warning and covers the zero-copy path per the testing convention.Test
./mvnw -pl zstd,integration-tests -am verify— 139 unit + 79 integration green, checkstyle + javadoc clean. IntelliJ: 0 warnings across all 27 main files.🤖 Generated with Claude Code