fix: ZstdSkippableContent defensively copies its bytes#21
Merged
Conversation
The record stored the caller's array and handed it back from content() uncopied, so a "value" object could be mutated through the input array or the accessor result. Clone in the compact constructor and in the content() accessor, matching ZstdDictionary's copy-in/copy-out. Add a test that mutating the source array and the accessor result leaves the record untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZstdSkippableContentis a value type, but it stored the caller'sbyte[]and returned it fromcontent()uncopied — so the "immutable" record could be mutated through the array passed to the constructor or the one handed back by the accessor.Clone in the compact constructor and in the
content()accessor, matchingZstdDictionary's copy-in (of) / copy-out (toByteArray) discipline.equals/hashCode/toStringkeep using the internal field directly (no extra copies).Found during a code-quality inspection of the module.
Test
New
defensivelyCopiesContentInAndOutasserts mutating both the source array and an accessor result leaves the record's bytes unchanged../mvnw -pl zstd -am testgreen, checkstyle + javadoc clean.🤖 Generated with Claude Code