chore: dedup ZDICT sample-flattening (Sonar gate)#24
Merged
Conversation
train / optimize / finalizeFrom each repeated the same block that packs the samples into one native buffer plus a parallel size_t[] of lengths, and the same produced-size error-check/copy-out tail. The recent null-validation edits marked these methods as "new code", so Sonar's quality gate failed on new_duplicated_lines_density (9.5%). Extract flatten() -> FlatSamples, toDictionary(), and requireNonEmpty(); the three trainers now share them. Behaviour and messages unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sonar quality gate went red on a single condition —
new_duplicated_lines_density = 9.5%— localized entirely toZstdDictionary.train/optimize/finalizeFromeach repeated the block that flattens the samples into one native buffer + a parallelsize_t[]of lengths, plus the same produced-size check / copy-out tail. The null-validation edits (#22) touched these methods, so the long-standing duplication started counting as new-code duplication.Extract three private helpers —
flatten(arena, samples) -> FlatSamples,toDictionary(dictBuf, produced, what), andrequireNonEmpty(samples, verb)— shared by the three trainers. No behaviour or message changes.Test
./mvnw -pl zstd,integration-tests -am test -Dtest=ZstdDictionaryTest,GoldenCorpusTest— green (incl. golden-dictionaries interop), checkstyle clean.🤖 Generated with Claude Code