refactor(test): tidy GoldenDictionaries imports and params#5
Merged
Conversation
- Import luben ZstdDictCompress/ZstdDictDecompress instead of FQN (no collision with the dfa1 ZstdCompressDict/ZstdDecompressDict names). - Drop the unused name parameter from the parameterized methods; the provider now yields Named<Path>, preserving the filename display name. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up cleanup to #4.
ZstdDictCompress/ZstdDictDecompressinstead of fully-qualified names — no collision with the dfa1ZstdCompressDict/ZstdDecompressDictnames. (lubenZstdstays FQN; it collides with the importedio.github.dfa1.zstd.Zstd.)nameparameter from the three parameterized methods. The provider now yieldsNamed<Path>, so the{0}display name is still the dictionary filename.Test
./mvnw -pl integration-tests -am test -Dtest='GoldenCorpusTest$GoldenDictionaries'— 3 green, checkstyle clean.🤖 Generated with Claude Code