Skip to content

hide left sidebar and switch to links#149

Closed
oadetayo wants to merge 9 commits intomainfrom
86-update-page-navigation
Closed

hide left sidebar and switch to links#149
oadetayo wants to merge 9 commits intomainfrom
86-update-page-navigation

Conversation

@oadetayo
Copy link
Copy Markdown
Contributor

Pull request overview

This PR replaces the use of shiny::tabPanel() with a hidden bslib::navset_hidden sidebar. The navigation is now handled via links

What is the current behaviour?

Previously, the app used a sidebar for navigation

What is the new behaviour?

The app now uses bslib::navset_hidden, which allows for a hidden sidebar navigation.
Users access different views via links instead of visible tab panels.

Copy link
Copy Markdown
Contributor

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change to how the dfe_contents function works, and a couple of other things:

  1. Can you update the units package in the lockfile - think it should be 0.8-7 now as they release a bug fix really quickly after the 0.8-6 release

  2. Can we add a bit more space / padding on the left of the contents so it's not as close to the side of the screen?

image

  1. Can we reduce the whitespace between the h1 on each page and the header - it's grown a bit with the move to the left navigation and it's too much now

image

@oadetayo oadetayo requested a review from cjrace March 26, 2025 10:05
cjrace
cjrace previously approved these changes Mar 27, 2025
Copy link
Copy Markdown
Contributor

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oadetayo! Happy those comments are resolved now, still some funky things going on style-wise, though happy for those to be picked up separately as I don't think they were introduced by this PR (same with the test failures)

@oadetayo oadetayo requested a review from cjrace March 31, 2025 09:31
@cjrace cjrace force-pushed the 86-update-page-navigation branch from a4c3ce5 to 3c3c353 Compare July 4, 2025 13:17
@cjrace cjrace dismissed their stale review July 16, 2025 12:49

Branch is almost ready to go in, though when updating and testing I noticed a couple of things still to address:

  1. Whitespace bar in the footer
  2. Bar of whitespace above header after cookies are accepted
  3. Whitespace above content is still a bit much (least important / can cope without changing)
Copy link
Copy Markdown
Contributor

@rmbielby rmbielby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things:

  1. We don't really need the accessibility, cookies and support panels linking from the sidebar as they're all linked from the footer already
  2. Those three above have a different page margin going on to the Example tab and user guide
  3. Bonus one, there is only one example tab, so could just remove the 1...

@cjrace
Copy link
Copy Markdown
Contributor

cjrace commented Oct 14, 2025

Done your changes above @rmbielby - now also fixing the footer links and adding backlinks in in line with the latest development version of shinyGovstyle, will push my changes up later

@rmbielby
Copy link
Copy Markdown
Contributor

rmbielby commented Apr 2, 2026

Abandoning this one as superseded by recent newer developments in shinyGovstyle.

@rmbielby rmbielby closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants