Add ability to ignore build files in packages #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfederm
reviewed
Feb 11, 2026
src/Tests/TestData/PackageReferenceWithFakeBuildFile/Library/Library.csproj
Outdated
Show resolved
Hide resolved
dfederm
reviewed
Feb 11, 2026
src/Tests/TestData/PackageReferenceWithFakeBuildFile/Library/Library.csproj
Outdated
Show resolved
Hide resolved
dfederm
approved these changes
Feb 11, 2026
Owner
|
So this isn't quite right. The suppression ends up having to happen up the entire tree, not just on the package which has the build files. Eg, I would expect an unused dependency on Microsoft.Extensions.Logging to require a suppression on Microsoft.Extensions.Logging.Abstractions (which actually has the build files), but I end up having to add one for Microsoft.Extensions.Logging, which does not. EDIT: Pushed some fixes for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a lot of packages are skipped from being trimmed because they / their dependencies contain any build files. This can be a simple props / targets file with no consequence, but msbuild task can't determine whether it's safe to remove or not, so such packages are skilled. Like
Microsoft.Extensions.Logging.Abstractions. This PR adds the ability for the user to have a list of such packages, so they're judged only whether they're used, and not on the presence of build filesAttempts to address #123