Skip to content

[WIP] Add conservative path filters to skip unaffected CI work#993

Merged
dgee2 merged 8 commits into
mainfrom
claude/phase-5-add-conservative-path-filters
Apr 21, 2026
Merged

[WIP] Add conservative path filters to skip unaffected CI work#993
dgee2 merged 8 commits into
mainfrom
claude/phase-5-add-conservative-path-filters

Conversation

@Claude

@Claude Claude AI commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>Phase 5: Add conservative path filters to skip unaffected CI work</issue_title>
<issue_description>## Summary
Use path-based conditions so frontend and backend jobs only run when relevant files change.

Why

This improves average CI throughput across the repo, even if it does not materially change every single run.

Guardrails

Keep filters conservative to avoid missing cross-stack changes.

Acceptance criteria

  • Frontend runs for ui/**, OpenAPI contract changes, and workflow changes
  • Backend runs for .cs, .csproj, solution, and workflow changes
  • No required validation is skipped for cross-stack changes</issue_description>

Comments on the Issue (you are @claude[agent] in this section)

Claude AI and others added 2 commits April 20, 2026 08:09
@Claude Claude AI requested a review from dgee2 April 20, 2026 08:12
@dgee2 dgee2 marked this pull request as ready for review April 20, 2026 08:15
Copilot AI review requested due to automatic review settings April 20, 2026 08:15
Comment thread .github/workflows/main.yml Fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces conservative CI path filtering so backend and frontend GitHub Actions jobs only run when relevant files change in pull requests, improving overall CI throughput while keeping push/manual runs fully validated.

Changes:

  • Add a changes job using dorny/paths-filter and gate backend/frontend jobs based on detected file changes.
  • Update frontend job dependencies and conditions to allow running when backend-build is skipped.
  • Add documentation describing the path filter behavior and guardrails.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
.github/workflows/main.yml Adds a changes detector job and conditional execution for backend/frontend jobs based on path filters.
docs/ci-path-filters.md Documents the CI path filter rules, expected behavior across event types, and testing/troubleshooting guidance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/ci-path-filters.md Outdated
Comment thread docs/ci-path-filters.md
Comment thread docs/ci-path-filters.md Outdated
Comment thread .github/workflows/main.yml Outdated
Comment thread docs/ci-path-filters.md Outdated
Comment thread .github/workflows/main.yml
@dgee2

dgee2 commented Apr 20, 2026

Copy link
Copy Markdown
Owner

@claude[agent] Fix the comments

@Claude

Claude AI commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/dorny/paths-filter/releases/latest
    • Triggering command: /usr/bin/curl curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Agent-Logs-Url: https://github.com/dgee2/Menu/sessions/7c7b022c-438b-456a-9086-a6f3e35ebbc4

Co-authored-by: dgee2 <5671841+dgee2@users.noreply.github.com>
@Claude

Claude AI commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

@claude[agent] Fix the comments

Fixed in 1dcb98a:

  • Added conditional to checkout step in changes job to avoid unnecessary work on non-PR runs
  • Clarified documentation to mention changes job runs on all PRs
  • Updated backend-only scenario description to be more accurate
  • Fixed test instructions and example savings to account for changes job

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/main.yml
Comment thread docs/ci-path-filters.md Outdated
Comment thread .github/workflows/main.yml Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 104 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/main.yml
Comment thread .github/workflows/main.yml
Comment thread docs/integration-tests.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 104 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dgee2 dgee2 enabled auto-merge (squash) April 21, 2026 07:39
@sonarqubecloud

Copy link
Copy Markdown

@dgee2 dgee2 disabled auto-merge April 21, 2026 19:43
@dgee2 dgee2 enabled auto-merge (squash) April 21, 2026 19:43
@dgee2 dgee2 merged commit 3b95b0a into main Apr 21, 2026
14 checks passed
@dgee2 dgee2 deleted the claude/phase-5-add-conservative-path-filters branch April 21, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phase 5: Add conservative path filters to skip unaffected CI work

4 participants