Repository navigation
Add outflow_source option to pi() (cape_star vs cape_env) and docume… - #85
Merged
Merged
Conversation
…nt sensitivity knobs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new configuration option for the
pifunction in thetcpyPIpackage, allowing users to choose how the outflow temperature and level are defined when calculating tropical cyclone potential intensity (PI). The changes add theoutflow_sourceparameter (with options"cape_star"and"cape_env"), update documentation and sample code to reflect this, and include new tests to ensure correct behavior.Key changes:
New Feature: Outflow Source Selection
outflow_sourceparameter to thepifunction, allowing users to select whether the outflow temperature/level is defined using the saturated CAPE* calculation ("cape_star", default) or the environmental CAPE calculation ("cape_env"). The implementation ensures the correct values are used based on the user's choice. [1] [2] [3]Documentation Updates
README.mdto document the newoutflow_sourceoption and other sensitivity/configuration options, including usage examples.src/tcpyPI/pi.pyto include the new parameter and clarify its behavior. [1] [2]API and Sample Code Adjustments
run_sample_datasetfunction inrun_sample.pyto accept theoutflow_sourceparameter and pass it through to thepifunction, updating both the function signature and docstring. [1] [2] [3]Testing
tests/test_outflow_source.pyto verify that bothoutflow_sourcemodes produce valid results and that invalid values raise appropriate errors.