ML fixes; properly import @tailwind & use @apply; fix ./json import#3
Open
trulycool wants to merge 3 commits intodgwyer:mainfrom
Open
ML fixes; properly import @tailwind & use @apply; fix ./json import#3trulycool wants to merge 3 commits intodgwyer:mainfrom
trulycool wants to merge 3 commits intodgwyer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings!
I filed an issue w/ your repo earlier. But as I continued to experiment, I noticed that tailwind was not properly integrated w/ the *.scss files...i.e. the @tailwind imports were not working, and I couldn't use the @apply directive.
Finding it unlikely that using SASS & PostCSS / Tailwind was necessary, I implemented the simplest fix.
Renamed all the *.scss files allow the @tailwind imports to work properly. It also allows use of the @apply directive, so that rather than reverting to custom CSS, you can do things like:
NOTE: #arbitrary-color-value has to be an actual valid CSS color value; used as example/documentation of what the brackets mean here...
Also fixed the ./json import error issue.
Thanks again for sharing your code!
I just started implementing custom Gutenberg blocks on a headless WordPress project, w/ SvelteKit & TailwindCSS for the frontend, and while Tailpress allows a similar end result (i.e. using Tailwind to style the blocks in the editor & frontend), having the blocks generate the actual compiled CSS seems like a great option for future projects, where perhaps Tailpress as the main theme wouldn't work.
All the best,
Morgan
😌🙏