Fix: tag filter causes "Maximum update depth exceeded" crash - #30
Merged
Conversation
Clicking a tag badge to filter subscriptions triggers an infinite re-render loop because: filteredSubscriptions is recomputed via .filter() on every render, producing a new array reference The useEffect that pushes this to the parent fires on every new reference Parent re-renders with new inline callback props, re-triggering the effect Fixed by: Wrapping filteredSubscriptions in useMemo Stabilizing parent callbacks with useCallback
Owner
|
merged. thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for Crash when filtering by a tag #29
Clicking a tag badge to filter subscriptions triggers an infinite re-render loop because:
filteredSubscriptions is recomputed via .filter() on every render, producing a new array reference
The useEffect that pushes this to the parent fires on every new reference
Parent re-renders with new inline callback props, re-triggering the effect
Fixed by:
Wrapping filteredSubscriptions in useMemo
Stabilizing parent callbacks with useCallback
Changes by Sonnet 4.6