Conversation
Collaborator
|
@dhasegan LGTM. Not much to review here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crawled for courses for both "Portfolio as of 2015" and "Portfolio as of 2013/14". Merged them together. Have to create some code that doesn't add them both.
Then parsed the details from campus net. I ignored all the modules work, so I just parsed for courses. Which is OK but not ideal. Who has time to write it properly?
Then spent a crusade to find the get_users script. Found it in jcollege (whoisjack) repo. Cannot run it because i dont have an account, so no VPN.
Deleted the images and the data from professors (we have to anyway parse again)
Ideally it would be cool to have the scripts properly written with arguments, have a readme and then just call a script
./get_me_data.pyand prepares everything for the populator. But we don't live in that world.