Close sockets with _RealWebSocket destructor#96
Open
james-richey-gv wants to merge 1 commit intodhbaird:masterfrom
Open
Close sockets with _RealWebSocket destructor#96james-richey-gv wants to merge 1 commit intodhbaird:masterfrom
james-richey-gv wants to merge 1 commit intodhbaird:masterfrom
Conversation
A new helper method, terminateConnection(), is added to ensure all the places where sockets are closed cause the socket file descriptor to become invalidated and the client to be put in the correct state. A destructor is added to call terminateConnection() ensuring resources are freed if the WebSocket object is destroyed. Finally, private copy constructor and copy assignment operator are added per the "Rule of Three" ensuring only one instance manages the socket. This should address issue dhbaird#71: Websocket::close() doesn't disconnect correctly. Calling WebSocket::close() still requests a clean disconnect; however, the socket is guaranteed to be closed when the WebSocket destructor is run.
|
_RealWebSocket& operator=(const _RealWebSocket&); VS2022 warning says "function definition for 'operator=' not found." Is there a definition required? ofc, WS should not be copied |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new helper method,
terminateConnection(), is added to ensure all the places where sockets are closed cause the socket file descriptor to become invalidated and the client to be put in the correct state.A destructor is added to call
terminateConnection()ensuring resources are freed if theWebSocketobject is destroyed.Finally, private copy constructor and copy assignment operator are added per the "Rule of Three" ensuring only one instance manages the socket.
This should address issue #71: Websocket::close() doesn't disconnect correctly. Calling
WebSocket::close()still requests a clean disconnect; however, the socket is guaranteed to be closed when theWebSocketdestructor is run.