[AMDGPU] Physical register tracking in GCN trackers.#1
Open
dhruvachak wants to merge 1 commit into
Open
Conversation
Previously, the GCN tracker only monitored virtual registers, leading to inaccurate register pressure estimates and sub-optimal scheduling decisions when physical registers were present. This patch adds support for tracking physical registers in GCN trackers. Virtual and physical register tracking are maintained separately. Similar to virtual LiveRegs, physical LiveRegs are now maintained. The tracking flow closely follows that of the GCN trackers in the recede, advance, and pressure-increment methods. Tracking physical registers leads to better register allocation, no more allocation failures, and more accurate pressure estimates. Existing tests have been updated to reflect the above. A new test schedule-gcn-physreg-pressure has been added that validates physical register tracking across multiple scenarios. Assisted-by: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the GCN tracker only monitored virtual registers, leading to inaccurate register pressure estimates and sub-optimal scheduling decisions when physical registers were present. This patch adds support for tracking physical registers in GCN trackers. Virtual and physical register tracking are maintained separately. Similar to virtual LiveRegs, physical LiveRegs are now maintained. The tracking flow closely follows that of the GCN trackers in the recede, advance, and pressure-increment methods.
Tracking physical registers leads to better register allocation, no more allocation failures, and more accurate pressure estimates. Existing tests have been updated to reflect the above. A new test schedule-gcn-physreg-pressure has been added that validates physical register tracking across multiple scenarios.
Assisted-by: Cursor