refactor(core): implement value semantics and optimize string analysis#17
Merged
dhruvanbhalara merged 1 commit intoMar 7, 2026
Merged
Conversation
- Implement value semantics using `collection` dependency for core models - Consolidate character set validation from `ConfigAwarePasswordValidator` into `PolicyValidationMixin` - Optimize string allocations in `containsAnyOf` by using `String.contains` directly - Fix `satisfiesPolicy` to evaluate base config even when policy is null - Add fallback pool size for passwords consisting entirely of unmapped characters - Align generator interfaces and update related tests
dhruvanbhalara
force-pushed
the
refactor/core-value-semantics-and-optimizations
branch
from
0ff6565 to
6139ff2
Compare
dhruvanbhalara
deleted the
refactor/core-value-semantics-and-optimizations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collectiondependency for core modelsConfigAwarePasswordValidatorintoPolicyValidationMixincontainsAnyOfby usingString.containsdirectlysatisfiesPolicyto evaluate base config even when policy is null