fix(utils): use Set for containsAnyOf character check#20
Merged
Conversation
Change character search in containsAnyOf to use a Set of runes. This matches the documentation's claim of O(1) character lookup and improves lookup speed.
Bump library version to 1.0.1 in pubspec.yaml and document the containsAnyOf performance fix in CHANGELOG.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Set-based lookup in the containsAnyOf string extension.
Currently, containsAnyOf uses a linear search on the input character pool string. For long strings and character lists, this can slow down performance. The documentation comment also states that a Set is used for O(1) character lookup, which was not the case in the implementation.
This change converts the input character pool to a Set of runes and searches the target string's runes against it. We also add test cases to test/utils/password_string_extensions_test.dart to verify correct lookup behavior.