Adding new peak callers#5
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27005d391d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## Write to file | ||
| for idx, sample_info in enumerate(sample_run_dict[sample_key][replicate]): | ||
| sample_id = "{}_{}_rep{}_T{}".format(sample_info[0], sample_info[1], replicate, idx + 1) | ||
| for sample_info in sample_run_dict[sample_key][replicate]: | ||
| sample_id = "{}_{}_rep{}".format(sample_info[0], sample_info[1], replicate) |
There was a problem hiding this comment.
Preserve unique IDs for technical replicates
When a group/condition/replicate has multiple technical replicates (supported earlier in this function and shown in the docstring), this now assigns the same sample_id to every row. That produces duplicate id values in the validated samplesheet, and downstream code (including the new meta.sample_id prefixes in this commit) uses these IDs for joins and published filenames, so technical replicates will collide and overwrite each other or be joined ambiguously. To avoid losing replicate-specific outputs, keep a unique suffix (e.g., the previous T{idx}) or otherwise disambiguate each row’s ID.
Useful? React with 👍 / 👎.
|
✅ Full pytest-workflow suite passed on Sherlock (Slurm). Branch: Most recent test-history entry ( 2026-01-09 — pytest-suite (Slurm)
|
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).