Skip to content

Adding new peak callers#5

Open
dhusmann wants to merge 19 commits into
differential_peak_callingfrom
adding_new_peak_callers
Open

Adding new peak callers#5
dhusmann wants to merge 19 commits into
differential_peak_callingfrom
adding_new_peak_callers

Conversation

@dhusmann
Copy link
Copy Markdown
Owner

@dhusmann dhusmann commented Jan 9, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/cutandrun branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 27005d391d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bin/check_samplesheet.py
Comment on lines 440 to +442
## Write to file
for idx, sample_info in enumerate(sample_run_dict[sample_key][replicate]):
sample_id = "{}_{}_rep{}_T{}".format(sample_info[0], sample_info[1], replicate, idx + 1)
for sample_info in sample_run_dict[sample_key][replicate]:
sample_id = "{}_{}_rep{}".format(sample_info[0], sample_info[1], replicate)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve unique IDs for technical replicates

When a group/condition/replicate has multiple technical replicates (supported earlier in this function and shown in the docstring), this now assigns the same sample_id to every row. That produces duplicate id values in the validated samplesheet, and downstream code (including the new meta.sample_id prefixes in this commit) uses these IDs for joins and published filenames, so technical replicates will collide and overwrite each other or be joined ambiguously. To avoid losing replicate-specific outputs, keep a unique suffix (e.g., the previous T{idx}) or otherwise disambiguate each row’s ID.

Useful? React with 👍 / 👎.

@dhusmann
Copy link
Copy Markdown
Owner Author

✅ Full pytest-workflow suite passed on Sherlock (Slurm).

Branch: adding_new_peak_callers
Commit: 91f2ff4

Most recent test-history entry (docs/test_history/adding_new_peak_callers.md):

2026-01-09 — pytest-suite (Slurm)

  • JobID/run dir: 13170828 — /scratch/users/dhusmann/nextflow-work/runs/pytest-suite/20260109_183946
  • Command: pytest-suite (pytest-workflow) --maxfail=1 --kwdof --symlink --ga --color=yes (via pytest_suite.sh)
  • Result: 323 passed, 0 failed (2:05:41), SLURM COMPLETED 0:0
  • Failures observed (prior attempt 13116667): Nextflow compile error "Variable ch_seacr_pairs/ch_macs_pairs already defined" in subworkflows/local/peak_calling_extended.nf; fix in 1491b92 (remove def on ch_*_inputs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant