Skip to content

ci: add ruff linting to CI and pyproject.toml - #6

Open
faizan-7890 wants to merge 1 commit into
dhyanamgit:mainfrom
faizan-7890:add-ruff-linting
Open

faizan-7890 wants to merge 1 commit into
dhyanamgit:mainfrom
faizan-7890:add-ruff-linting

Conversation

@faizan-7890

Copy link
Copy Markdown

Closes #3

Summary

This PR adds Ruff linting configuration and integrates a lint check step into GitHub Actions CI, addressing all requirements in #3.

Changes

  1. pyproject.toml:
    • Added [tool.ruff] section targeting py310 with line-length = 120.
    • Configured [tool.ruff.lint] selecting ["E", "F", "W"] (pycodestyle errors, pyflakes, and pycodestyle warnings).
    • Ignored noisy rules:
      • E501 (line length > 120): Long string literals, URLs, and SOAP XML envelopes.
      • E702 (multiple statements on one line with semicolon): Common pattern across test fixtures (await a.close(); await b.close()).
      • E731 (lambda assignment): Used in tests for short mock callables.
      • E402 (module level import not at top of file): Used intentionally in signaling.py to resolve circular imports.
      • E741 (ambiguous variable name): Single-letter iterator variables (l in list comprehensions).
    • Added ruff>=0.4 to [project.optional-dependencies] under dev.
  2. tests/requirements-test.txt:
    • Added ruff>=0.4 so test environments include the linter out of the box.
  3. .github/workflows/tests.yml:
    • Added a run: ruff check . step in the unit test matrix job right before running pytest.
  4. Codebase Cleanup:
    • Resolved 22 unused imports (F401) and 4 unused local variables (F841) across src/ and tests/ so that ruff check . completes with zero errors out of the box.
  5. CHANGELOG.md:
    • Added entry under ## Unreleased documenting the addition of Ruff linting to CI.

Verification

  • Ran ruff check . locally — All checks passed (0 errors).
  • Ran unit test suite via pytest — 144 passed.

Contributor Agreement

I agree to the nodemeet Contributor Agreement in CONTRIBUTING.md.

Copilot AI balanced review requested due to automatic review settings October 7, 2026 18:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b52f9c15-6851-412f-9a1c-a3b9b33fd8f7
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first pull request to nodemeet! 🎉 Please make sure the contributor agreement line from CONTRIBUTING.md is in the description. Once it's merged you'll be added to CONTRIBUTORS.md.

@faizan-7890

Copy link
Copy Markdown
Author

Hi @dhyanamgit,

The required contributor agreement line from CONTRIBUTING.md is included in the PR description:

I agree to the nodemeet Contributor Agreement in CONTRIBUTING.md.

All Ruff lint checks pass cleanly with 0 errors, and the unit test suite passes. Ready for your review and merge whenever you have a moment! Thank you!

@faizan-7890

Copy link
Copy Markdown
Author

Implemented and verified. Ruff is configured in pyproject.toml, added to the development/test dependencies, and runs in CI via
uff check .. Local validation passes with zero Ruff errors, and the unit test suite passes with 144 tests. Closes #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ruff linting to CI

2 participants