Skip to content

Add collapsible drawer with available scenarios#270

Draft
biamalveiro wants to merge 4 commits into
mainfrom
bia-scenario-drawer
Draft

Add collapsible drawer with available scenarios#270
biamalveiro wants to merge 4 commits into
mainfrom
bia-scenario-drawer

Conversation

@biamalveiro

Copy link
Copy Markdown
Contributor

This PR is currently a draft

Goal

Convert the initial new scenario button to a collapsible drawer where it's possible to view and open available scenarios.
Based on these Figma mockups.

Description

The change to a drawer has implications for the possible tab interactions.

  • A new tab will show on the list iff it has been committed (its world is created)
  • We need to limit the number of right tabs that exit to avoid overlapping issues with the drawer.
  • In the drawer, should we show an indication that a tab is already open?
  • Should it be possible to delete scenarios from the drawer (permanently delete scenario)

biamalveiro and others added 4 commits June 27, 2024 16:11
Correct a bug where literal protos would always return an Expression
with a nil AnyExpression. Also return Literal instead of Expression,
and correctly fill in the name and token positions.
@biamalveiro
biamalveiro force-pushed the bia-scenario-drawer branch from b0628fb to 2cc35a3 Compare July 4, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants