Repository navigation
test(a11y): the accessibility tests after generic containers and static text, and CI on the fork's runners - #13
Merged
Merged
Conversation
…bel by its tag Since 934dc42 an element with no role of its own is a generic container, and a page's text is static text with the Label role. The hidden tests now look for the div itself, the semantic page expects no Unknown element, and the labelled-by tests find the <label> element by tag instead of whichever Label node the hash order gave first.
The warp-* runners are upstream's WarpBuild runners; in the fork those jobs waited for a runner that never came. WPT gets a longer timeout on the smaller runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork's CI first ran on #12, and Test (macos) and Test (linux) failed in blitz-tests' accessibility tests. They fail on `leaf` too: the tests predate two of the fork's own changes in 934dc42.
No library code changes. Locally the whole `blitz-tests` suite passed 8 runs out of 8 (317 tests), and the hidden test still fails when the div is not hidden.
The second commit moves Test (windows) and WPT off upstream's WarpBuild runners (`warp-*`), which the fork doesn't have, so those jobs waited forever. Windows now uses `windows-2025`. WPT uses `ubuntu-24.04-arm`, with a 60-minute timeout instead of 15 because this runner is smaller.
WPT results
Subtests: 1621 newly passing, 652 newly failing (net +969). Tests: 20 added, 130 removed. Crashes: +25. Timeouts: -2.
Subtest changes by area (72 areas)
Full diff (265 changed tests)
Generated by the WPT workflow.