Repository navigation
feat(tui): borders that meet are joined, and an edge takes its nearest column - #14
Merged
Merged
Conversation
…t column Each box drew its own border, so a table's cells, ruled one by one, read as boxes side by side. The painter now records each border cell's arms and, once the page is painted, joins a line's end to a line running towards it: ┬, ┼, ├. Only cells painted as borders and still showing them take part, and only within one layer, so a box-drawing character in the page's text stays as written and a menu's sides do not meet the rules under it. A border's columns now take the cell boundary nearest each edge, as its rows already did. Taffy rounds a box to whole pixels, so a box that ended on a cell boundary could end a fraction past it, and its right side took the next box's first column. Behavioural-change: borders of boxes in one layer that touch are drawn joined, and a right or left side can move one column to the boundary nearest it.
adammharris
added a commit
to diaryx-org/leaf
that referenced
this pull request
Oct 22, 2026
…s fit the grid The prototype hands the editor its cell as Type::grid and drops its own CSS for the find bar and the status line. A table's cell lines keep out of the line-width workaround, which moved right-aligned text off its padding. Blitz comes from the fork's tui-junctions branch, which joins borders that meet, until diaryx-org/blitz#14 merges into leaf. The proposal marks decision 2 as made.
adammharris
added a commit
to diaryx-org/leaf
that referenced
this pull request
Oct 22, 2026
…the joined borders have merged diaryx-org/blitz#14 merged tui-junctions into leaf, so every Blitz crate comes from leaf, as apps/leaf-dioxus takes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For leaf's terminal editor (diaryx-org/leaf#20), whose tables are now laid out in whole cells with a rule a cell wide or a row high.
Joined borders. Each box draws its own border, so a table whose cells are ruled one by one read as boxes side by side. The painter now records each border cell's arms and, after the page is painted, joins a line's end to a line running towards it:
Only cells painted as borders, and still showing them, take part, and only within one layer. So box-drawing characters in the page's text stay as written, a menu over a rule hides it, and a menu's sides don't join the rules beside it. Each hoisted child (a positioned, z-indexed box) is its own layer.
Nearest column. A border's left and right sides now take the cell boundary nearest each edge, as its top and bottom already did. Taffy rounds a box to whole pixels, so a box laid out to end on a cell boundary could end a fraction past it, and with
floorits right side took the next box's first column, under that box's text.Tests: two new paint tests, the joined grid and a box over it.
cargo test -p blitz-tui(13) and-p tui_counter(3) pass; fmt is clean;clippy -p blitz-tui --no-deps -D warningsis clean. Clippy without--no-depsfails inblitz-dom(needless_return,mutator.rs:1271) on local Rust 1.99, which this PR doesn't touch.WPT results
Subtests: 1621 newly passing, 652 newly failing (net +969). Tests: 20 added, 130 removed. Crashes: +25. Timeouts: -2.
Subtest changes by area (72 areas)
Full diff (265 changed tests)
Generated by the WPT workflow.