Repository navigation
fix(dom): pass over elements that are not rendered when Tab moves focus - #20
Merged
Merged
Conversation
`focus_next_node` and `focus_prev_node` took any focusable element, so Tab reached buttons inside a `display: none` element (a page's closed menus, which unit keeps in the tree from the first frame) and `visibility: hidden` ones. Nothing showed where focus went, and the accessibility tree, which leaves such elements out, was handed a focus it did not contain, which AccessKit panics on. A browser's sequential focus skips what is not rendered; so does this. Behavioural-change: Tab and Shift-Tab no longer focus an element that is `visibility: hidden` or inside a `display: none` element.
adammharris
force-pushed
the
tab-skips-hidden
branch
from
October 23, 2026 17:31
ab604b0 to
005d582
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
focus_next_nodeandfocus_prev_nodetook any focusable element, so Tabreached buttons inside a
display: noneelement (a page's closed menus,which unit keeps in the tree from the first frame) and
visibility: hiddenones. Nothing showed where focus went, and the accessibility tree, which
leaves such elements out, was handed a focus it did not contain, which
AccessKit panics on. A browser's sequential focus skips what is not
rendered; so does this.
Test:
tab_order_tests::tab_passes_over_what_is_not_rendered. Independent of the a11y-modal branch, which separately makes the AX tree fall back to the window when focus is outside it.