Repository navigation
The whole Blitz stack here: the click action, the winit backends, and the iOS example - #3
Merged
Merged
Conversation
blitz-shell left an AccessKit action request undone. A click (VoiceOver's activate, an agent's AXPress) is now carried out as a hand would: the pointer moved to the middle of the node's box, inside the safe area, pressed and released there, through the window's own events, so the node acts on it exactly as on a real click. View::click_events gives those events for any node, and View::accessibility_action_events for an action request, for an embedder that runs its own event loop and feeds window events through its own handling (leaf's Mac app, which did this itself in access.rs). BlitzApplication carries them out itself. Behavioural-change: an AccessKit click request on a node now clicks it; before it was ignored.
winit-appkit and winit-uikit 0.31.0-beta.3, the backends dioxus-native pins, patched (each PATCH.md says how and why), move here from diaryx-org/leaf's patches/. They are pinned by the blitz-shell this branch carries and move when it does, so a consumer takes its whole Blitz stack, winit included, from one repository and one branch. Their history stays in leaf; each PATCH.md says where. They are outside this workspace, taken by consumers through [patch.crates-io].
examples/ios-a11y is leaf's spikes/blitz-ios-a11y, moved here beside the Blitz and the winit-uikit it tests, and taking both by path from this checkout. It carries out a click asked for with View::click_events rather than its own copy of it. Run on an iPhone 17 simulator, iOS 27: XCUITest finds the button by its label and frame and taps it, and accessibilityActivate (VoiceOver's double tap) presses it through click_events, inside the safe area: "Pressed 2 times".
The whole Blitz stack here: the click action, the winit backends, and the iOS example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2 merged into
unitrather thanleaf. It was stacked on #1, and GitHub didn't retarget it when #1 merged. This brings the same commits intoleaf. See #2 for what they do and how they were verified.leaf's Mac app and flower's Dioxus app take
winit-appkitfrom this branch: flower'smainalready does (diaryx-org/flower#3), and leaf's will once this lands.