Repository navigation
docs(tasks): the command-line tests run without the command line - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
docs/tasks/cli-tests-run-without-the-cli.mdand lists it in the tasks index. Docs only: no code or CI change.Why
cargo test --no-default-featuresfails at 63d273c. All 33 tests intests/cli.rspanic withthe binary this test crate builds: ... NotFound. Thefig-schemabinary hasrequired-features = ["cli"], but the auto-discoveredtests/cli.rstarget does not, so withoutcliit still compiles and runs a binary that was never built. The library itself is fine in that configuration: its 118 unit tests, 15non_exhaustivetests and 18 doctests pass, andcargo clippy --no-default-features --all-targets -- -D warningsis clean.The library-only build is the one every consumer uses. prov, flower and twig-export all depend on
fig-schema = { version = "0.5", default-features = false }. CI only checks default features, so nothing tests that build, and its test command cannot pass today.The task's done state is to declare
tests/cli.rsas a[[test]]withrequired-features = ["cli"]. Whether CI should also get a library-only job, like historica-minisign'sverify-only, is left as a separate decision.How it was found and checked
masterwithcargo test --no-default-features --no-fail-fast. The counts in the task come from that run.[[test]]entry,cargo test --no-default-featurespasses (118 + 15 + 18) andcargo test --test cliwith defaults still runs and passes all 33.ship ciin this branch's worktree passed all 5 jobs (fmt, clippy, test, doc, msrv).