Repository navigation
docs(tasks): a wrong entry hides its mapping's type mismatch from check - #5
Merged
adammharris merged 1 commit intoNov 9, 2026
Conversation
Schema::check drops a container's type mismatch whenever any descendant
already reported one. That is right for a list, which admits its items,
but a mapping under a scalar type is wrong for its own reason, so
`meta: {author: 3}` under `meta.**: str` reports only meta.author while
`explain` says meta is not str either.
adammharris
deleted the
agent/backlog-file-a-wrong-entry-hides-its-mappings-mismatch
branch
November 9, 2026 20:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Files a task,
docs/tasks/a-wrong-entry-hides-its-mappings-mismatch.md, and lists it indocs/tasks/tasks.md. No code changes.Why
Schema::checkstops reporting a mapping's own type mismatch as soon as any node under it mismatches too. Withmeta.**typedstr:meta: {author: Ann}→meta: expected str, found mapmeta: {author: 3}→ onlymeta.author: expected str, found int. The mapping's error is gone, althoughexplainstill saysmeta … not str: expected str, found map.The cause is
item_already_saidinjudge(src/check.rs). It counts a mismatch on any descendant, and its reasoning ("a list that does not fit is one with an item that does not") is only true of a sequence. The task gives the repro, the cause, and when it counts as done. The fix is left for anagent/backlog-a-wrong-entry-hides-its-mappings-mismatchbranch.Verified
fig-schemabinary built from006b101(master). The task's console output is copied from that run.-D warnings, test, doc), plus test and clippy with--no-default-features, are all green, so nothing else catches this.prov checkfinds no root), so the task file was written by hand followingdocs/tasks/tasks.md.