Repository navigation
fix(mac): declare the ZON document type - #7
Merged
Merged
Conversation
The Open panel offered `zon` and flower-core opens it, but Info.plist declared no type for it, and `.zon` has no system UTI, so the Mac app could not open one. Import org.ziglang.zon and list it among the document types as an Alternate editor, as org.diaryx.fig is. A test in file.rs holds the plist to the extension the panel offers. Closes docs/tasks/closed/open-zon.md. Behavioural-change: Flower.app is offered for `.zon` files, in the Finder's Open With and in its Open panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
apps/flower-dioxus/Info.plistnow importsorg.ziglang.zon(extensionzon, conforming topublic.plain-text) and lists it inCFBundleDocumentTypesas anAlternateeditor. This is the same shape asorg.diaryx.fig. The plist's header comment now covers both imported types.A new test in
apps/flower-dioxus/src/file.rsholds the plist to thezonextension the Open panel offers.Why
flower-core has opened ZON since fig 7, and
file.rsalready offeredzon, but the Mac app declared no type for it..zonhas no system UTI, so the app has to import one.Task
Closes
docs/tasks/open-zon.md, now atdocs/tasks/closed/open-zon.md. It was moved withprov mv --in, becauseorg shelveacts on the main checkout.Verification
ship ci: all 7 jobs pass (fmt, clippy, test, package-isolation, bindings, dioxus, msrv).plistlibparses the file and reads back both new declarations.prov checkreports no findings.Not verified on a Mac. This was checked on Linux against the plist alone. Nobody has yet tried Open With in the Finder, or whether the Open panel enables a
.zonfile. The test is a text check on the plist, not a Launch Services check.