Skip to content
This repository was archived by the owner on Nov 12, 2026. It is now read-only.

docs(tasks): close heading-at-offset; make the find-bar ^c test pass without a pasteboard - #19

Merged
adammharris merged 2 commits into
mainfrom
agent/backlog-heading-at-offset
Oct 21, 2026
Merged

adammharris merged 2 commits into
mainfrom
agent/backlog-heading-at-offset

Conversation

@adammharris

Copy link
Copy Markdown
Member

What changed

  • Closes docs/tasks/heading-at-offset.md. The task was still open, but only provui's half remained, and that half has landed. provui d512e25 (refactor(core)!: ask leaf for the heading under the caret instead of parsing the body again provui#5) has DocumentSession::heading_at_caret delegate to leaf's Doc::heading_at_caret, and twig is out of provui-core's manifest. leaf's own half (d15bbb7) and the test the done-when asks for (heading_at_caret_is_the_nearest_heading_above) were already here. The status now names both commits, and the task is shelved into docs/tasks/closed/ with prov mv --in, so tasks.md and closed.md follow.
  • test(tui): the_bar_hands_the_host_s_own_chords_back_to_the_host required the status "copied". On a machine with no pasteboard (hbox, a headless Linux box), clipboard_copy reports "clipboard unavailable", so cargo test --workspace failed there on main. Either report proves ^C reached the clipboard verb instead of being swallowed by the find bar, and that's what the test checks. The other clipboard tests already skip without a pasteboard. No behaviour change.

Verification

On hbox (Linux), ship ci:

  • versions, fmt, clippy, test, package-isolation: green. leaf-tui's tests failed before the test fix and pass after it.
  • dioxus: the widget's fmt, both clippy runs and its tests are green, and so is the app's fmt. The app's clippy and tests cannot compile on Linux: apps/leaf-dioxus/src/platform has only a macos module. This PR doesn't touch either Dioxus tree, so that part is untested here and needs a Mac.
  • prov check: no findings.

Not done

can-undo-counts-edits-not-steps.md stays open. Its done-when says provui's DocumentSession "can drop its walk-on-when-the-body-did-not-move special case". provui 03dda9a kept that branch and reframed it: a body move that changes nothing is now read as twig failing, and the walk carries on. Whether that counts as done is a call for provui.

…board verb

the_bar_hands_the_host_s_own_chords_back_to_the_host required the status "copied", so it failed on any machine without a pasteboard (a headless Linux box), where clipboard_copy reports "clipboard unavailable". Either report means ^c reached the verb rather than being swallowed by the find bar, which is what the test is about; the other clipboard tests already skip when there is no pasteboard.
…vui#5

provui d512e25 has DocumentSession::heading_at_caret delegate to leaf's Doc::heading_at_caret and takes twig out of provui-core's manifest, the last of the task's done-when. Shelved into docs/tasks/closed with prov.
@adammharris
adammharris merged commit 5d71997 into main Oct 21, 2026
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant