This repository was archived by the owner on Nov 12, 2026. It is now read-only.
Repository navigation
docs(tasks): close heading-at-offset; make the find-bar ^c test pass without a pasteboard - #19
Merged
Merged
Conversation
…board verb the_bar_hands_the_host_s_own_chords_back_to_the_host required the status "copied", so it failed on any machine without a pasteboard (a headless Linux box), where clipboard_copy reports "clipboard unavailable". Either report means ^c reached the verb rather than being swallowed by the find bar, which is what the test is about; the other clipboard tests already skip when there is no pasteboard.
…vui#5 provui d512e25 has DocumentSession::heading_at_caret delegate to leaf's Doc::heading_at_caret and takes twig out of provui-core's manifest, the last of the task's done-when. Shelved into docs/tasks/closed with prov.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
docs/tasks/heading-at-offset.md. The task was still open, but only provui's half remained, and that half has landed. provuid512e25(refactor(core)!: ask leaf for the heading under the caret instead of parsing the body again provui#5) hasDocumentSession::heading_at_caretdelegate to leaf'sDoc::heading_at_caret, andtwigis out ofprovui-core's manifest. leaf's own half (d15bbb7) and the test the done-when asks for (heading_at_caret_is_the_nearest_heading_above) were already here. The status now names both commits, and the task is shelved intodocs/tasks/closed/withprov mv --in, sotasks.mdandclosed.mdfollow.test(tui):the_bar_hands_the_host_s_own_chords_back_to_the_hostrequired the status"copied". On a machine with no pasteboard (hbox, a headless Linux box),clipboard_copyreports"clipboard unavailable", socargo test --workspacefailed there on main. Either report proves^Creached the clipboard verb instead of being swallowed by the find bar, and that's what the test checks. The other clipboard tests already skip without a pasteboard. No behaviour change.Verification
On hbox (Linux),
ship ci:apps/leaf-dioxus/src/platformhas only amacosmodule. This PR doesn't touch either Dioxus tree, so that part is untested here and needs a Mac.prov check: no findings.Not done
can-undo-counts-edits-not-steps.mdstays open. Its done-when says provui'sDocumentSession"can drop its walk-on-when-the-body-did-not-move special case". provui03dda9akept that branch and reframed it: a body move that changes nothing is now read as twig failing, and the walk carries on. Whether that counts as done is a call for provui.