Repository navigation
ci: validate the interop object alone with rocfl - #5
Merged
adammharris merged 1 commit intoNov 1, 2026
Merged
Conversation
rocfl 1.7.0 validating the interop directory as a storage root reports the missing root declaration (E069) and exits 2, and under set -e and pipefail the step stopped before its grep could tell that apart from an object error, so the job failed on every push although the object was valid. Name the object with --paths interop-object and let rocfl's exit status decide: 0 for the object the interop test writes, 2 once a content file fails fixity (E092).
adammharris
deleted the
agent/backlog-fix-rocfl-check-fails-on-a-valid-object
branch
November 1, 2026 22:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The
Validate it with rocflstep in.github/workflows/ci.ymlnow runsrocfl -r "$RUNNER_TEMP/interop" validate --paths interop-objectand rocfl's exit status decides the step. The
pipefail/tee/grepwrapper is gone. The README's interop instructions name the object the same way, and the task is marked done.Why
rocfl 1.7.0 treats the interop directory as a storage root. That directory has no root declaration, so rocfl reports E069 and exits 2 however valid the object is. Under
set -eandpipefailthe step stopped before thegrepthat was meant to tell this apart from an object error. As a result,rocfl cross-validationhas failed on every push tomain. Naming the object makes rocfl check the object alone.Closes
docs/tasks/rocfl-check-fails-on-a-valid-object.md.Verification
On hbox, with
cargo install rocfl --no-default-features --locked(1.7.0), against the objectcargo test --test interopwrites:rocfl -r $OUT validate: exit 2 (the failure on main)rocfl -r $OUT validate --paths interop-object: exit 0, "valid with warnings"v1/content/letter.md: exit 2, E092 fixity failure, so a bad object still fails the jobThe
test / clippy / fmtjob's commands also pass locally:cargo fmt --all --check,cargo clippy --all-targets -- -D warnings,cargo test --all-targetswithOCFL_FIXTURESset, andcargo test --doc. This PR's own CI run is the check of the workflow itself.