Repository navigation
build(deps)!: move to fig 7 and twig 6 - #10
Merged
Merged
Conversation
prov's main is on fig 7 and twig 6, and plates takes prov from main:
fig and twig reach this workspace through it, so their majors are
plates' too. Both are pure Rust now, and both cores name no language.
- fig is taken at 7 for the appearance types' derive macros, the one
thing plates asks of it directly.
- A twig format is a handle a language crate registers, not a
`twig::Format::Markdown` variant. `twig_format` and the parses in
`body`, `embed` and `template` get theirs from `twig-markdown`,
`twig-djot` and `twig-html` as prov re-exports them
(`prov::prov_graph`), so the handle names a row in the twig prov
registered rather than in a second copy.
- `MarkdownExtensions { directives: true, .. }` is the feature list
`["directives"]` (`Document::parse_with_features`,
`Editor::new_with_features`). twig refuses a feature a language does
not declare, so Djot and HTML are asked for none, where the struct
used to be passed to every grammar and ignored by two.
- `prov::Format::Yaml` is `prov::MetaFormat::Yaml`.
- The `yaml`, `json`, `toml` and `fig-lang` features are gone from all
three crates. They gated nothing of plates' own and only forwarded to
prov's, which prov removed: it always compiles in the four dialects.
- CI stops installing Zig.
Behavioural-change: The `yaml`, `json`, `toml` and `fig-lang` features
no longer exist on `plates`, `plates-render` or `plates-cli`; a
manifest that names one fails to resolve. Drop it: every build now
reads YAML, JSON, TOML and figl metadata, where the default build
read YAML only.
Behavioural-change: Only frontmatter is read as a document's metadata,
as prov now reads it: `---` YAML, `+++` TOML and `---<lang>`. A
source whose metadata is a `;;;` JSON block, a fenced ```` ```yaml ````
or ```` ```fig ```` block, ```` ```endmatter ````, or an HTML
`<script>`/`<pre><code>` island is collected as having no metadata —
no title, audience or id from it, so a gate on `audience` leaves it
off the site — and the block publishes as body text if the page is
published at all.
Behavioural-change: plates requires fig 7. A caller deserializing the
appearance types (`ThemeAppearance`, `ColorPalette`, …) with fig's `FromValue`
must be on fig 7 too; a fig 5 `Value` is a different type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves plates onto prov's current
main, which has moved to fig 7 and twig 6 (diaryx-org/prov#12). Without this, plates no longer builds against provmain: it turns onprov/fig-langand namesprov::Format, and both are gone.Changes
cargo update -p prov. twig-doc goes from 4.0.1 to 6.0.0, the twig language crates come in, and the twig-sys crates leave.version = "7", withdefault-features = falseand only thederivefeature.yaml,json,tomlandfig-langare gone from plates, plates-render and plates-cli. They only forwarded to prov's features, which no longer exist, and gated nothing in plates itself.twig::Format::Markdown/Djot/Htmlbecome the language crates'format(). plates reaches those crates through prov's re-exports, so it uses the same twig as prov.MarkdownExtensions { directives: true }becomes the"directives"feature name.visibility::extensions()is nowfeatures(), and returns that feature for Markdown only, because twig refuses a feature a language doesn't declare.prov::Formatbecomesprov::MetaFormat..config/ship.figl. READMEs and manifest comments updated.Behavioural changes
These are also
Behavioural-change:trailers on the commit.---,+++and---<lang>frontmatter is read as metadata. A source using;;;JSON, a fenced block, endmatter or an HTML island now collects with no metadata. Anaudiencegate therefore leaves it off the site, and if it is published anyway, the block shows up as body text.FromValuemust be on fig 7 too.Checks
Every job in
.config/ship.figlpasses locally:--all-features -D warnings)Generated by Claude Code